Initial commit. by Grzegorz-Smagacz-Mobica · Pull Request #3 · Mobica/Vulkan-Samples

Grzegorz-Smagacz-Mobica · 2023-08-03T19:22:37Z

Description

Please include a summary of the change, new sample or fixed issue. Please also include relevant motivation and context.
Please read the contribution guidelines

Fixes #

General Checklist:

Please ensure the following points are checked:

Note: The Samples CI runs a number of checks including:

I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

I have tested the sample on at least one compliant Vulkan implementation
If the sample is vendor-specific, I have tagged it appropriately
I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
Any dependent assets have been merged and published in downstream modules
For new samples, I have added a paragraph with a summary to the appropriate chapter in the samples readme
For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering

Patryk-Jastrzebski-Mobica

it's not all there is, but enough for the moment

Patryk-Jastrzebski-Mobica · 2023-08-04T11:40:08Z

samples/extensions/sparse_image/CMakeLists.txt

+    CATEGORY ${CATEGORY_NAME}
+    AUTHOR "Mobica"
+    NAME "sparse_image"
+    DESCRIPTION "Sample description"


add description

Patryk-Jastrzebski-Mobica · 2023-08-04T11:41:37Z

samples/extensions/sparse_image/README.md

don't forget to add sample and feature descriptions and Mobica copyright information

Patryk-Jastrzebski-Mobica · 2023-08-04T11:41:47Z

shaders/sparse_image/shader.vert

@@ -0,0 +1,18 @@
+#version 450


add Mobica copyright information

Patryk-Jastrzebski-Mobica · 2023-08-04T11:42:07Z

shaders/sparse_image/shader.frag

@@ -0,0 +1,44 @@
+#version 450


add Mobica copyright information

Patryk-Jastrzebski-Mobica · 2023-08-04T12:02:26Z

samples/extensions/sparse_image/CMakeLists.txt

+    NAME "sparse_image"
+    DESCRIPTION "Sample description"
+    SHADER_FILES_GLSL
+        "shader.vert"


use full path sparse_image/shader.vert and rename the shader name e.g. to sparse.vert

Patryk-Jastrzebski-Mobica · 2023-08-04T12:04:43Z

samples/extensions/sparse_image/sparse_image.cpp

+	VK_CHECK(vkCreateGraphicsPipelines(get_device().get_handle(), pipeline_cache, 1, &pipeline_create_info, nullptr, &sample_pipeline));
+}
+
+void sparse_image::setup_camera()


camera should be setup in constructor

Patryk-Jastrzebski-Mobica · 2023-08-04T12:07:12Z

samples/extensions/sparse_image/sparse_image.cpp

+
+void sparse_image::generate_mips()
+{
+	VkCommandBuffer command_buffer = begin_single_time_command();


use device->create_command_buffer();
and end it device->flush_command_buffer();

Patryk-Jastrzebski-Mobica · 2023-08-04T12:10:53Z

samples/extensions/sparse_image/sparse_image.h

+		alignas(16) glm::mat4 proj;
+	};
+
+	struct SimpleBuffer


This structure is not needed and not using it correctly can cause performance problems. Use vkb::core::Buffer, which uses VMA.

Patryk-Jastrzebski-Mobica · 2023-08-04T12:12:05Z

samples/extensions/sparse_image/sparse_image.h

+		size_t         size;
+	};
+
+	struct SimpleVertex


Consider using Vertex struct. You can find it in api_vulkan_sample.h

Patryk-Jastrzebski-Mobica · 2023-08-04T12:13:44Z

samples/extensions/sparse_image/sparse_image.cpp

+
+	VK_CHECK(vkAllocateDescriptorSets(get_device().get_handle(), &set_alloc_info, &descriptor_set));
+
+	VkDescriptorBufferInfo descriptor_buffer_info{};


use this method: create_descriptor()

…odel. Instead, whole mesh is calculated using MVP transformation matrix which makes calculations way more trouble-proof. MINOR: some quick changes, using already written wrappers for some functionalities, and adding some descriptions here and there.

…fragment shader - from now the shader checks if the required fragment is resident in the memory before sampling from it (no explicit calculations required,shader will sample from whatever is ACTUALLY available). On the CPU side, workload was divided into stages, many phases removed/rewritten.

* Fixed run-time errors from validation layers * Changed .md to .adoc style

…rame is rendered. * Removed transition_mip_layout() and replaced it with vkb::image_layout_transition(). * Minor bugs and typos.

…ts + allow to toggle color highlighting * Added additional uniform buffer containing data needed by fragment shader * Removed call to bind_sparse_image() from free_unused_memory() as it is redundant * Merged UPDATE_AND_GENERATE and FREE_UNUSED_MEMORY stages * Removed virtual_texture.free_list as it is redundant * Replaced virtual_texture.bind_list with to_be_bound flag under the virtual_texture.page_table * Changed available_memory_index_list from std::list to std::vector * Minor bugs / code refactoring

* Block update is now better prioritized to update the closest areas first * Refactoring

* Memory defragmentation can be enabled for the better memory management

* From now number of vertical/horizontal blocks can be changed from the UI * Number of blocks processed per-frame can be customized from UI too * Frame-counter mechanism can be enabled/disabled from the UI * Moved sparse_queue to separate (if possible) queue family, other than graphics queue * Introduced synchronization between binding the image and submitting the image * update_and_generate() was reduced to single command_buffer and one-time flush() * Several minor reworks/fixes for better code styling and efficiency

* Put additional descriptions to README.adoc * Minor issues, cleanups & typo's

* Minor typos and reworks

* unified copyrights

Grzegorz-Smagacz-Mobica requested review from Dawid-Lorenz-Mobica, Krzysztof-Dmitruk-Mobica, Patryk-Jastrzebski-Mobica and pawel-jastrzebski-mobica August 3, 2023 19:22

Patryk-Jastrzebski-Mobica reviewed Aug 4, 2023

View reviewed changes

Grzegorz-Smagacz-Mobica force-pushed the sparse_image branch 2 times, most recently from a5bf9da to 9d48a41 Compare September 27, 2023 13:08

Grzegorz-Smagacz-Mobica force-pushed the sparse_image branch from 00b5a16 to be170d8 Compare October 30, 2023 15:11

Grzegorz-Smagacz-Mobica added 18 commits December 4, 2023 12:26

Initial commit.

90fa6bd

update

c40b917

Core functionalities are working as expected. To be reviewed.

d839c92

Minor updates, mostly cleanup

b349e47

Clang Tidy Check fixes

77e41b7

Clang Format Check fixes

03d3fb6

* Rebased with main branch

38c906b

* Fixed run-time errors from validation layers * Changed .md to .adoc style

* Now loading the least detailed mip level is done before the first f…

2cda0c3

…rame is rendered. * Removed transition_mip_layout() and replaced it with vkb::image_layout_transition(). * Minor bugs and typos.

* Fixed the bug that caused black-spots to appear on screen

5b8ad7f

* Block update is now better prioritized to update the closest areas first * Refactoring

* Now memory is allocated dynamically during the run-time

d79749a

* Memory defragmentation can be enabled for the better memory management

* Updated the screenshot

dd9a846

* Put additional descriptions to README.adoc * Minor issues, cleanups & typo's

* Minor changes to match the PR's General & Sample Checklists

39b4c1f

* Fixed Ubuntu compilation issues and Copyright checks

23941f6

* Minor typos and reworks

* Minor stylistic changes

73197ca

Grzegorz-Smagacz-Mobica force-pushed the sparse_image branch from 0f0b0ad to cd50971 Compare December 4, 2023 11:28

* Rebase

813dce0

* unified copyrights

Grzegorz-Smagacz-Mobica force-pushed the sparse_image branch from cd50971 to 813dce0 Compare December 4, 2023 14:10

* missing static_cast

6a72036

* minor rework, fixing a validation layer warning

b166c91

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial commit.#3

Initial commit.#3
Grzegorz-Smagacz-Mobica wants to merge 21 commits intomainfrom
sparse_image

Grzegorz-Smagacz-Mobica commented Aug 3, 2023

Uh oh!

Patryk-Jastrzebski-Mobica left a comment

Uh oh!

Patryk-Jastrzebski-Mobica Aug 4, 2023

Uh oh!

Patryk-Jastrzebski-Mobica Aug 4, 2023

Uh oh!

Patryk-Jastrzebski-Mobica Aug 4, 2023

Uh oh!

Patryk-Jastrzebski-Mobica Aug 4, 2023

Uh oh!

Patryk-Jastrzebski-Mobica Aug 4, 2023

Uh oh!

Patryk-Jastrzebski-Mobica Aug 4, 2023

Uh oh!

Patryk-Jastrzebski-Mobica Aug 4, 2023

Uh oh!

Patryk-Jastrzebski-Mobica Aug 4, 2023

Uh oh!

Patryk-Jastrzebski-Mobica Aug 4, 2023

Uh oh!

Patryk-Jastrzebski-Mobica Aug 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		VK_CHECK(vkAllocateDescriptorSets(get_device().get_handle(), &set_alloc_info, &descriptor_set));

		VkDescriptorBufferInfo descriptor_buffer_info{};

Conversation

Grzegorz-Smagacz-Mobica commented Aug 3, 2023

Description

General Checklist:

Sample Checklist

Uh oh!

Patryk-Jastrzebski-Mobica left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants